Support STORAGE_RESOURCE_BINDING_ARRAY on Metal #8464
+13
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msvbg
force-pushed
the
storage_resource_binding_array
branch
from
a5304ee to
a638db8
Compare
msvbg
force-pushed
the
storage_resource_binding_array
branch
from
a638db8 to
9d371f3
Compare
cwfitzgerald
requested changes
Nov 12, 2025
Member
cwfitzgerald
left a comment
cwfitzgerald
left a comment
There was a problem hiding this comment.
Code looks good, some testing related issues:
- Could you add METAL to the targets list in
- Could you run the tests and make sure that the binding_array_storage_buffers and parital_binding_array_storage_buffers are running and passing?
- The issue with cargo-deny, you can add the git for metal-rs to deny.toml for now.
- The linux failure should fix itself with a rebase/merge of main.
Author
|
Okay after further work on this PR, I've realized that binding arrays of storage textures work (great!) but binding arrays of buffers are totally broken. Fully supporting buffers in binding arrays seems to require more work in Naga, and it feels like a bigger rabbithole than I want to go down right now. I've reduced the scope of the PR to only support storage textures in binding arrays now, not buffers. This also means no metal-rs changes. |
cwfitzgerald
approved these changes
Nov 26, 2025
Member
cwfitzgerald
left a comment
cwfitzgerald
left a comment
There was a problem hiding this comment.
Alright looks fine - though the user won't be able to know that storage buffers aren't supported, but that's fine as a stop gap, are the tests for storage textures running/passing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Depends on gfx-rs/metal-rs#366.
Description
This PR supports using binding arrays of storage textures on Metal.
Testing
I have tested this change locally on my M3 MacBook with Metal 3, and my shaders are able to bind and use the binding arrays as expected.
Squash or Rebase?
Fine to squash.
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.